1. Founder Premium Upgrade

    Joined:
    Apr 5, 2011
    Messages:
    20,679
    Trophy Points:
    102,160
    Ratings:
    +15,143
  2. Gluupor Builder
    Builder ⛰️ Ex-Mayor ⚒️⚒️ Prestige ⭐ I ⭐

    Joined:
    Jun 2, 2017
    Messages:
    189
    Trophy Points:
    7,940
    Gender:
    Male
    Ratings:
    +125
    only receiving exp for one mob killed (killed 4 blazes received 10 exp as opposed to 40)

    if i am not mistaken this is the wrong way round:

    ExperienceOrb exp = (ExperienceOrb) dead.getWorld().spawnEntity(dead.getLocation(), EntityType.EXPERIENCE_ORB);

    exp.setExperience(sm.expTools.multiplyExperience(originalExperience, subtractAmount));

    he spawns the orb before setting its experience so i guess the orb spawns with 0 exp and the only 10 exp i get is the exp the entit(blaze) will drop on kill by default.
    it was actually done the other way round, calculate exp then spawn the orb, before the change.

    put it in spoiler since theres prolly some other issues after i did some testing one being the fact that hes still doing

    "multiply-exp-enabled"

    instead of

    "multiply-exp.enabled"

    after changing the config. i changed it to that and got multiplied exp but it was weird values that didnt reflect the amount of mobs i killed.

    and im actually too tired to test any other possibilities...
     
    #22 Gluupor, Jun 19, 2018
    Last edited: Jun 19, 2018
  3. Founder Premium Upgrade

    Joined:
    Apr 5, 2011
    Messages:
    20,679
    Trophy Points:
    102,160
    Ratings:
    +15,143
    I’m using his new default config.
    So it’s broken yet again?
     
    #23 andrewkm, Jun 19, 2018
    Last edited: Jun 19, 2018
  4. Gluupor Builder
    Builder ⛰️ Ex-Mayor ⚒️⚒️ Prestige ⭐ I ⭐

    Joined:
    Jun 2, 2017
    Messages:
    189
    Trophy Points:
    7,940
    Gender:
    Male
    Ratings:
    +125
    yes its broken and i found the cause. create an issue please i will add my findings maybe submit a fix...

    hes doing an "add" instead of a "multiplication" when doing the calculation for the exp ... copy and paste error
     
  5. Founder Premium Upgrade

    Joined:
    Apr 5, 2011
    Messages:
    20,679
    Trophy Points:
    102,160
    Ratings:
    +15,143
  6. Gluupor Builder
    Builder ⛰️ Ex-Mayor ⚒️⚒️ Prestige ⭐ I ⭐

    Joined:
    Jun 2, 2017
    Messages:
    189
    Trophy Points:
    7,940
    Gender:
    Male
    Ratings:
    +125
    i added my findings so far.
    might submit a fix after work if i find some time.
     
  7. Founder Premium Upgrade

    Joined:
    Apr 5, 2011
    Messages:
    20,679
    Trophy Points:
    102,160
    Ratings:
    +15,143
  8. Gluupor Builder
    Builder ⛰️ Ex-Mayor ⚒️⚒️ Prestige ⭐ I ⭐

    Joined:
    Jun 2, 2017
    Messages:
    189
    Trophy Points:
    7,940
    Gender:
    Male
    Ratings:
    +125
    i submitted a PR. when this goes live the config needs to be like:

    multiply-exp:
    # Multiplies the experience dropped on kill-all/kill-step.
    enabled: true
    # Algorithms that should be used for multiplying experience.
    # LEGACY - algorithm used in StackMob v2.2.9 and older
    # MINIMAL - only add a small amount of extra experience.
    # NORMAL - the default amount of extra experience.
    # GENEROUS - adds a significant amount of extra expierence.
    # CUSTOM - use a custom multiplier for the extra experience.
    # CUSTOM_RANDOM - same as CUSTOM but makes multiplier a bit random.
    algorithm: CUSTOM
    # Used when the CUSTOM or CUSTOM_RANDOM mode is used above.
    custom-multiplier: 1.0

    algorithm: CUSTOM and multiplier to 1.0

    this will resemble what we had before. doing the config change without the fix i submitted will leave use with players getting exp for one additional mob that was actually never killed. (kill 3 get exp for 4 which isnt intended at least from your perspective i guess ^^)
     
  9. Founder Premium Upgrade

    Joined:
    Apr 5, 2011
    Messages:
    20,679
    Trophy Points:
    102,160
    Ratings:
    +15,143
    @Gluupor now live.
    Please test and let us know.
     
  10. Gluupor Builder
    Builder ⛰️ Ex-Mayor ⚒️⚒️ Prestige ⭐ I ⭐

    Joined:
    Jun 2, 2017
    Messages:
    189
    Trophy Points:
    7,940
    Gender:
    Male
    Ratings:
    +125
    works as intented .. again... not getting too little or too much (as you did recently) exp