Minecraft Username:
Gluupor

Brief Description:
killing >1 mobs from a stack only yields exp for the first and a fraction for every other mob killed

Instructions:
have a stack of mobs (for the ease of testing i recommend blaze as they yield exactly 10exp per mob)
kill >1
see how you only get 10 for the first mob a fraction of exp for every additional mob killed

How many times did you recreate this?:
couple times, one time i took the following screenshots

Result:
gained 12 exp after killing 4 blazes

Expected Result:
gain 40 exp as supposed to (referring to the test i made the screenshots with)
or whatever scaling the plugin config had before the update of the plugin (i know that kill-step in the config was messed up as well after updating)

Evidence:

i made sure the spawner was actually not spawning to avoid having faulty results due to restacking.

amount in stack before:


amount of exp before:


amount in stack after:


amount of exp after:

 

thx @andrewkm i added a comment to the report as to what i think might be the cause of the issue. bear with me tho i took java classes back during my apprenticeship but thats quite some time ago and i just occasionally do some silly more or less useful coding lol

 

i added a comment to the github issue. maybe @JamieSinn is able to confirm if i am actually correct about my assumption or not.

 

before:


killed 4; expected 40 got 27:


killed another 3; expected 30 got 19:


still not getting the exp the amount of mobs killed would actually give.
tbh im not even sure what the change he made was supposed to do he added a (imo) random add to the calculation. is this supposed to be some sort of scaling? why is it hardcoded if it is ...

 

https://github.com/Nathat23/StackMob-2/pull/62

this should actually work now. he is doing the -1 on calling multiplication because the entity drops exp by default. then again the additional subtraction was giving faulty results.
i also added a "multiply-exp-scaling" option to the config that gets used in the calculation when "multiply-exp-enabled" is true. so in case the need for scaling exp up or down for whatever reason: its possible.

 

i edited it in eclipse locally and tested it locally as well. with the scaling being 1 it gives exactly 10 xp per blaze killed. with scaling like 0.9 it gives 10 for the first blaze (as this is a default drop) and 9 for every additional blaze killed.

 

i made a change so it actually provides a default in case the config isnt updated right away. again bear with me its been some time but i wanted to help and couldnt get over it lol

 

the PR was merged hoping to see the fixes on the server soon :D

 

confirmed: killing mobs now gives the expected amount of exp