Sticky [ShopDB] Applications, Suggestions, Bug Reports, Feedback, FAQ

Discussion in 'General Discussion' started by Kozz, Nov 7, 2020.

  1. bsqt

    bsqt Head of Sports
    Mythic ⚔️ I ⚔️ ECC Sponsor President ⛰️⛰️ Ex-EcoLegend ⚜️⚜️⚜️⚜️ Prestige ⭐⭐ X ⭐⭐ Gameplay Architect Premium Upgrade

    Joined:
    Feb 6, 2012
    Messages:
    500
    Trophy Points:
    75,010
    Gender:
    Male
    Ratings:
    +337
    Hi Kozz, hope you are well.

    Noticed a problem with ShopDB.

    For example there is an entry to buy a skulkerbox for free in cammys town called "bunny" (https://shopdb.ecocitycraft.com/shops?page=1&q=shulker+box), but the shop sits inside a plot which is named "bunnyshops1". The plot is the region that is listed to shopdb, but this subsequently breaks the /warp button as the warp is /warp bunny not /warp bunnyshops1.

    Not sure if anything can be done for this.
     
  2. Kozz

    Kozz Builder
    Builder ⛰️ Ex-President ⚒️⚒️ Gameplay Architect

    Joined:
    Jan 11, 2017
    Messages:
    272
    Trophy Points:
    28,460
    EcoDollars:
    $0
    Ratings:
    +430
    Just an update on this, as expected after the server restarted the region is showing on ShopDB so you should now be able to list it!
    Exchange - Regions - ShopDB (ecocitycraft.com)

    I assumed this was an issue with the ShopDB code so was looking into that today, but I'm unable to reproduce this issue now, even for regions that were just created today :confused:. So, I'm not really sure what happened but it appears this may have been an intermittent issue that resolved itself after the server restarted. I'll keep an eye on it and will definitely look out for any related reports.

    In this case, I would recommend unlisting "bunnyshops1" and listing "bunny" instead, which should resolve the issue. Once that is done and the shops are used/restocked/etc, it should be listed under "bunny" in ShopDB again.

    There's a section on the docs that explains how this logic works:


     
  3. Kozz

    Kozz Builder
    Builder ⛰️ Ex-President ⚒️⚒️ Gameplay Architect

    Joined:
    Jan 11, 2017
    Messages:
    272
    Trophy Points:
    28,460
    EcoDollars:
    $0
    Ratings:
    +430
    Quick update, small bugfix:
    When accessing a search directly from a URL, e.g, Diamond Ore - Chest Shops - ShopDB (ecocitycraft.com), previously the search bar would not be populated with the search query.

    I have fixed this so now when loading a page directly from a URL, the relevant text is populated in the search bar.
    Hopefully this helps avoid confusion!
     
  4. angrylemon334

    angrylemon334 Resident
    Resident ⛰️

    Joined:
    Apr 25, 2023
    Messages:
    2
    Trophy Points:
    205
    Gender:
    Male
    Ratings:
    +3
    Bug report
    Code:
    In as much detail as possible, please describe the bug:
    The shopdb seems to incorrectly display per count price. It seems it is rounding down to 0 decimal places.
    I listed Yellow Dye (qty 10, B 39.99) for sale, and the website shows a count price of ($3.00/Count)

    Please note I'm unsure if this occurs with other materials. Most likely seems like it does.

    How many times have you encountered this:
    1

    Can this bug be intentionally recreated? If so, please describe the steps to make this bug occur:
    Yes.

    Step 1. Create a ChestShop
    Step 2. Place Yellow Dye inside box
    Step 3. Place sign on chest using the following parameters:
    Line 1: blank
    Line 2: 10
    Line 3: B 39.99 : S 20.31
    Line 4: ?

    Step 4. Wait for /shopdb list
    Step 5. Go to shopdb website, search for listing.
     
    • Agree Agree x 1
    • Winner Winner x 1
    • Informative Informative x 1
    • List
  5. Kozz

    Kozz Builder
    Builder ⛰️ Ex-President ⚒️⚒️ Gameplay Architect

    Joined:
    Jan 11, 2017
    Messages:
    272
    Trophy Points:
    28,460
    EcoDollars:
    $0
    Ratings:
    +430
    Hmm… Well that definitely isn’t right!

    Thanks for letting me know! I will look into this and work on a fix.
     
    • Like Like x 1
    • Winner Winner x 1
    • List
  6. Kozz

    Kozz Builder
    Builder ⛰️ Ex-President ⚒️⚒️ Gameplay Architect

    Joined:
    Jan 11, 2017
    Messages:
    272
    Trophy Points:
    28,460
    EcoDollars:
    $0
    Ratings:
    +430
    Update: I have found the issue and this has now been fixed!
    This bug would present itself when a total amount's decimal amount is 99 cents, e.g, $xx.99

    The item mentioned above is now listed as $4.00/Count:

    [​IMG]

    Technically it is $3.999, however, this amount is rounded to the nearest hundredth.

    Thanks for letting me know and providing a specific example! I appreciate your help making ShopDB better :)
     
    • Winner Winner x 2
    • Friendly Friendly x 1
    • List
    #206 Kozz, Apr 26, 2023
    Last edited: Apr 26, 2023
  7. Kozz

    Kozz Builder
    Builder ⛰️ Ex-President ⚒️⚒️ Gameplay Architect

    Joined:
    Jan 11, 2017
    Messages:
    272
    Trophy Points:
    28,460
    EcoDollars:
    $0
    Ratings:
    +430
    Another bugfix -

    Previously, when changing a search query while a previous one is still loading, the old results could override the new ones such as in the GIF below:

    [​IMG]

    I've fixed this by canceling any in-flight queries when you search for something new:

    [​IMG]

    This should help provide a smoother experience, especially when toggling between options or changing search queries quickly. :)

    Another update on something I will be working on - I noticed the chest shop queries take ~half a second:

    [​IMG]

    This isn't terrible, but I feel like I can make this at least twice as fast. Will be working on that when I have some more time.
     
    • Winner Winner x 2
    • Friendly Friendly x 1
    • Useful Useful x 1
    • List
    #207 Kozz, Apr 27, 2023
    Last edited: Apr 27, 2023
  8. Kozz

    Kozz Builder
    Builder ⛰️ Ex-President ⚒️⚒️ Gameplay Architect

    Joined:
    Jan 11, 2017
    Messages:
    272
    Trophy Points:
    28,460
    EcoDollars:
    $0
    Ratings:
    +430
    This is now complete.
    I have made some updates to ShopDB that have significantly increased its performance.

    Chest shop searches, latency (average)
    Previous: 620ms
    Now: 188ms

    Improvement: 3.3x

    Region searches, latency (average)
    Previous: 846ms
    Now: 183ms

    Improvement: 4.62x

    Player searches, latency (average)
    Previous: 1467ms
    Now: 168ms

    Improvement: 8.73x

    So overall, these changes have made ShopDB ~5.5x faster!
    The site should definitely be feeling more responsive overall.

    If you experience any issues, it could be due to the old version of the site being cached by your browser.
    If this happens, here are some steps that may fix that:
    • Try performing a hard refresh of the page (with the tab open, press CTRL+SHIFT+R).
    • Try using an incognito window, or clearing your cache.
    • If the above does not work, open a bug report on this thread.
    As with any other ShopDB changes, I'll be on the lookout for any related bug reports!
    Cheers! :)
     
  9. tanger91

    Mythic ⚔️ I ⚔️ EcoLegend ⛰️⛰️⛰️⛰️ Ex-Mayor ⚒️⚒️ Prestige ⭐⭐ XI ⭐⭐ Gameplay Architect Premium Upgrade

    Joined:
    Jun 21, 2014
    Messages:
    171
    Trophy Points:
    64,410
    Gender:
    Male
    Ratings:
    +74
    Bug Report

    In as much detail as possible, please describe the bug:
    In the Regions tab of Station 6 it shows the last owner chest shop information on the item sold and purchased tab but the signs/chest shop doesn't exist in game.
    See Shop In Game:


    See ShopDB:


    @tanger91, I tried the unlist and add commands it still shows alarah as having the chest shops in station6.
    /shopdb unlist station6
    /shopdb list station6

    How many times have you encountered this:
    Once.

    Can this bug be intentionally recreated? If so, please describe the steps to make this bug occur:
    I don't know maybe?
    Not sure if these are the exact steps??
    Create a chest shop in one of the stations in the market
    Then have the shop listed in shopdb.
    Then have a admin+ use there "tools" to remove the shop
    I assume one of the admins step is also to remove the shop is to unlist the shop?
    Have a new owner of a station.
    Then have the shop relisted in shopdb.
     
    • Informative Informative x 1
    • List
    #209 tanger91, Jun 18, 2023
    Last edited: Jun 18, 2023
  10. Kozz

    Kozz Builder
    Builder ⛰️ Ex-President ⚒️⚒️ Gameplay Architect

    Joined:
    Jan 11, 2017
    Messages:
    272
    Trophy Points:
    28,460
    EcoDollars:
    $0
    Ratings:
    +430
    First, apologies for the delayed reply!

    Thanks for bringing this to my attention. When a shop gets cleared with admin tools, ShopDB unfortunately is not able to detect the deletion of the shops, resulting in the "stale shops" you are seeing now. To address this, a new command will be added soon, "/shopdb clearshops <region-name>" which will allow both staff and owners of a region to clear out all the shops and can be used in cases such as this where an old shop is lingering on ShopDB but does not exist in the game.

    I have coordinated with staff and this will be part of the procedure followed when they are clearing out shops which should prevent players from having to do so.

    Lastly, I have corrected station6 manually so you do not have to :). As always, thanks for the report and helping make ShopDB better!
     
  11. FuriuosGeorge

    FuriuosGeorge I got answers and am no longer curiuos
    Mythic ⚔️ I ⚔️ Moderator ECC Sponsor Tycoon ⛰️⛰️⛰️ Ex-President ⚒️⚒️ Prestige ⭐ IV ⭐ Premium Upgrade

    Joined:
    Jun 27, 2016
    Messages:
    824
    Trophy Points:
    47,510
    Gender:
    Male
    Ratings:
    +361
    I hope this is still where to post shop dB suggestions.

    Since spawner references don't change for each instance of a spawner is it possible to add a reference table to the system that will display the type of spawner instead of "SpawnerA"
     
  12. RealRichNixon

    RealRichNixon Pres. Richard Nixon by day, GameAdmin by night.
    Mythic ⚔️ I ⚔️ Game Admin EcoLegend ⛰️⛰️⛰️⛰️ Ex-President ⚒️⚒️ Prestige ⭐ V ⭐ Premium Upgrade

    Joined:
    Oct 17, 2013
    Messages:
    1,604
    Trophy Points:
    70,410
    Gender:
    Male
    Ratings:
    +461
    I did discover an issue regarding some items when delving in to what FuriuosGeorge suggested above.

    The issue comes with capitalization. An example I ran across is with spawners. Searching "spawner#a" currently yields something of this nature.
    https://prnt.sc/lr0Li274SPhy

    Notice how bsqt has two entries for spawner#a. This is not necessarily the case; bsqt has just one sign for spawner#a, and one sign for spawner#A from what I could see at that shop. Ignoring capitalization leads to some confusion; #a represents a Skeleton Horse Spawner, while #A represents an Ocelot Spawner. These are two different spawners that are being recognized as one due to capitalization.

    Potential fixes as far as I'm aware include collating the data according to a specific charset (with _cs). Taking a quick look into the code, it looks like this is a fix to be made in how distinct materials are being found in the database in findDistinctMaterialNames() circa line 250 of src/main/java/com/ecocitycraft/shopdb/database/ChestShop.java. I could very well be wrong though, so as always, please do test locally.

    --

    Once the above is remedied, I have compiled spawner /iteminfos into one neat table:
    https://prnt.sc/0oNsFALoZu8_

    I suppose one could make a mapping between spawners and their in-game names in various different ways, but a check will likely be wanted for if the material is a spawner and has a "hashtag", to get that "hashtag" part and resolve it to a name. At some place near the front-end, the item name could be adjusted to allow for it to be searched accordingly (I'm going to assume the search bar uses values from /chest-shops/material-names), and this item name could be given to the user in place of "spawner#A".

    --

    Thanks for having a read; hopefully my infinitesimal wisdom helps someone somewhere.
     
  13. NossaFlossa

    Mythic ⚔️ I ⚔️ EcoLegend ⛰️⛰️⛰️⛰️ Ex-EcoLegend ⚜️⚜️⚜️⚜️ Prestige ⭐ VI ⭐ Premium Upgrade

    Joined:
    May 30, 2012
    Messages:
    1,308
    Trophy Points:
    74,660
    Gender:
    Male
    EcoDollars:
    $30,218,044
    Ratings:
    +994
    Hello, I'm not sure if this has been suggested before.

    Currently, I don't see a reason to own a market station when town warps are superior. There's no need to deal with stock regulations, you have practically unlimited space and the freedom to use any block you want for building. There's no renewal fee, since towns are a one-time purchase that lasts forever. I'm suggesting a buff to market stations by giving them ShopDB priority. Maybe list large shops first, small shops second and then the rest. I'd like to see market station competition like in the old days.
     
    #213 NossaFlossa, Nov 16, 2023
    Last edited: Nov 17, 2023
  14. Moosagi

    Moosagi President
    President ⛰️⛰️ Ex-Mayor ⚒️⚒️

    Joined:
    Jun 2, 2015
    Messages:
    89
    Trophy Points:
    38,610
    Gender:
    Male
    Ratings:
    +40
    Hi! Can something please be done to allow users to request re-evaluation of a chest shop? Currently charlienr1's shops have been misreporting for literally months. Occasionally I see this and it's just really annoying.
     
    • Agree Agree x 2
    • Winner Winner x 1
    • List
  15. dred73

    dred73 EcoMaster
    EcoMaster ⛰️⛰️⛰️⛰️ Ex-EcoLegend ⚜️⚜️⚜️⚜️ Prestige ⭐ IV ⭐

    Joined:
    Sep 30, 2019
    Messages:
    240
    Trophy Points:
    34,810
    Gender:
    Male
    Ratings:
    +80
    Hi Kozz,
    So now that we are on 1.21, I added the new Chiseled Copper block and the new Copper Grate block to my town at /warp everything
    It's not showing up though on ShopDB. it's been a few hours, I know there is some time needed for the auto update but remember it being every 20 minutes or something shorter. Thanks for all you do around here to keep us always updated and up and running, etc. . . . .
     
  16. RealRichNixon

    RealRichNixon Pres. Richard Nixon by day, GameAdmin by night.
    Mythic ⚔️ I ⚔️ Game Admin EcoLegend ⛰️⛰️⛰️⛰️ Ex-President ⚒️⚒️ Prestige ⭐ V ⭐ Premium Upgrade

    Joined:
    Oct 17, 2013
    Messages:
    1,604
    Trophy Points:
    70,410
    Gender:
    Male
    Ratings:
    +461
    They are showing for me as of right now. Maybe it took some extra time to update.
     
  17. dred73

    dred73 EcoMaster
    EcoMaster ⛰️⛰️⛰️⛰️ Ex-EcoLegend ⚜️⚜️⚜️⚜️ Prestige ⭐ IV ⭐

    Joined:
    Sep 30, 2019
    Messages:
    240
    Trophy Points:
    34,810
    Gender:
    Male
    Ratings:
    +80
    They are now showing for me as well. I jumped the gun here and posted too early.