Minecraft Username: subxplorer Brief Description: Right click a "sell" trade sign, once your inventory is full money will continue to come out of your balance if the trade sign still has items in it. Instructions: 1. Find a "Sell" trade sign that is stocked. 2. Have a full inventory. 3. Right click the trade sign. How many times did you recreate this bug?: 3+ times I even had Oreo verify. I lost 44 Nstars last night (from a trade sign) I could not figure out how it happened. After doing some more experimenting this morning I discovered this bug with trade signs Result: When you right click on a "sell" trade sign you get the item and money leaves your balance, however once your inventory is full money continues to leave your balance and the items in the trade sign keep dropping (like you are buying them). Expected Result: When a players inventory is full and they right click a "sell" trade sign they should get an "You don't have room" message instead of money being taken from their balance. Evidence: None, but very easy to duplicate
@JamieSinn please look into this. If you find the issue, please get a ticket in github so we can track all this properly and work at it one by one.
That is normal, it's called the terrible "Butcher", I suggest not dropping any kind of items, just passing them in a chest since it's even safer due to it logs and if someone tries to scam you you could have evidence.
We're going to begin fixing stuff up throughout this week. I took Saturday/Sunday off to basically do whatever I want and take a break - humans need that once in a while
Thank you Jamie, I can't seem to keep my fool self from forgetting this is a problem and am pouring money into signs right and left >.<
Any ETA on this? This is an economy server so Trade Signs are rather important. This bug has existed for some time as well as the related bug (where if there is less than a stack of items in a sign and you have a full inventory when you break the signs the items in the signs simply disappear.) These bugs have been costly to me and others and are quite frustrating for players. I personally have broken a sign and lost over 50 Nstars, and I can only guess the number of times I was buying items and did not realize my inventory was full. It has been over two months since this bug was first reported. If these bugs won't be or can't be fixed than please say so and add them to the "Common Bugs Thread".
I have had no problems with this glitch, but as I was selling quartz blocks to @rockboy2000 . He lost some because I had sold more then an inv full. Please fix this staff because it will most likely affect other users and my shop in the near future. <3
This is still being looked into, but it is much more intensive than expected, and will take a very large amount of work to resolve.
Isn't this the time when @kukelekuuk00 jumps in and waves his magic wand and tells us how to fix this issue in one or two minutes? jkjk: Jamie, you are doing a great job for our community and I thank you for everything you have accomplished for us.
At this point I can't even do that. I reckon the code changed a little to accomodate the offhand slot. No magic fix from me! I'm sure Jamie knows what the problem is, though.
Knowing the problem and knowing the solution are two very different things I know what is wrong, just not how to fix it.
using "getStorageContents()" instead of "getContents()" might work. I don't know if you've tried that yet.
