[Bug Report] Server Trade Sign Error

Discussion in 'Help & Support / Errors & Bugs' started by THCOOL, Oct 12, 2016.

  1. THCOOL

    THCOOL SolarNation Founder and Ex-smod
    Builder ⛰️ Ex-Mayor ⚒️⚒️ Premium Upgrade

    Joined:
    Jun 7, 2013
    Messages:
    1,233
    Trophy Points:
    42,010
    Gender:
    Male
    Ratings:
    +781
    Minecraft Username: @THCOOL

    Brief Description: I was buying some sandstone from the server shop. It sells at 264 per click meaning that my inventory should fill up quickly. I clicked for a continuous minute and noticed that my inventory was indeed full, however the sign would still take my money.

    Instructions: Fill your entire inventory. Go to server block shop. Start buying an item. Notice how your inventory is completely full, yet it is still taking money from you

    How many times did you recreate this bug?: A few (4-5)

    Result: Sign continued to take my money ($7,000 total) after my inventory was already full

    Expected Result: I expected to receive an error message stating that there was no room in my inventory and it wouldn't let me buy more until I made space

    Evidence: Showing that my inventory is completely full:[​IMG]
    It taking my money even though my inventory is already full:
    [​IMG]
     
    #1 THCOOL, Oct 12, 2016
    Last edited: Oct 12, 2016
  2. Riggs316

    Riggs316 The Ultimate Rigger
    Mythic ⚔️ I ⚔️ EcoLegend ⛰️⛰️⛰️⛰️ Ex-EcoLegend ⚜️⚜️⚜️⚜️ Prestige ⭐ I ⭐ Premium Upgrade

    Joined:
    May 1, 2014
    Messages:
    719
    Trophy Points:
    68,410
    Gender:
    Male
    Ratings:
    +769
    It's due to the offhand slot being empty. When there's nothing in your offhand, the signs think you still have inventory space. It's a known bug, I'm just not sure if there's a solution in the works beyond put something in your offhand for the time being when you buy from signs like that.
     
    • Winner Winner x 1
    • Informative Informative x 1
    • List
  3. 314

    314 Irrational SuperMod, former ServerAdmin
    SuperMod EcoLegend ⛰️⛰️⛰️⛰️ Ex-President ⚒️⚒️ Prestige ⭐ VI ⭐ Premium Upgrade

    Joined:
    Apr 1, 2014
    Messages:
    7,055
    Trophy Points:
    97,160
    EcoDollars:
    $2,400,000
    Ratings:
    +4,921
    Correct.
    www.ecocitycraft.com/forum/threads/trade-signs-stealing-money.147611
    However, some of my tests showed that this bug kept existing with an item in the offhand slot.
     
    • Informative Informative x 1
    • List
  4. andrewkm

    Founder Premium Upgrade

    Joined:
    Apr 5, 2011
    Messages:
    20,683
    Trophy Points:
    102,160
    Ratings:
    +15,143
  5. JamieSinn

    JamieSinn Retired Lead Administrator/Developer
    Builder ⛰️ Ex-Tycoon ⚜️⚜️⚜️ Premium Upgrade

    Joined:
    Jun 4, 2011
    Messages:
    5,517
    Trophy Points:
    78,090
    Gender:
    Male
    Ratings:
    +4,588
    Same trade sign issue as before.
    I'll do my best, but this is probably a decent overhaul
     
  6. JamieSinn

    JamieSinn Retired Lead Administrator/Developer
    Builder ⛰️ Ex-Tycoon ⚜️⚜️⚜️ Premium Upgrade

    Joined:
    Jun 4, 2011
    Messages:
    5,517
    Trophy Points:
    78,090
    Gender:
    Male
    Ratings:
    +4,588
  7. THCOOL

    THCOOL SolarNation Founder and Ex-smod
    Builder ⛰️ Ex-Mayor ⚒️⚒️ Premium Upgrade

    Joined:
    Jun 7, 2013
    Messages:
    1,233
    Trophy Points:
    42,010
    Gender:
    Male
    Ratings:
    +781
    It is not. Tested it out again and got the same original result. Still bugged
     
  8. matrix_rep

    matrix_rep Runner Up in BB20
    Mythic ⚔️ I ⚔️ ECC Sponsor Resident ⛰️ Ex-EcoLegend ⚜️⚜️⚜️⚜️ Prestige ⭐⭐ XI ⭐⭐ Premium Upgrade

    Joined:
    Feb 5, 2014
    Messages:
    4,676
    Trophy Points:
    102,160
    Gender:
    Male
    Ratings:
    +7,453
    Could take a restart to make changes
     
    • Informative Informative x 1
    • Friendly Friendly x 1
    • List
  9. JamieSinn

    JamieSinn Retired Lead Administrator/Developer
    Builder ⛰️ Ex-Tycoon ⚜️⚜️⚜️ Premium Upgrade

    Joined:
    Jun 4, 2011
    Messages:
    5,517
    Trophy Points:
    78,090
    Gender:
    Male
    Ratings:
    +4,588
    No, we haven't updated yet.
     
    • Winner Winner x 2
    • Like Like x 1
    • List
    #9 JamieSinn, Oct 18, 2016
    Last edited: Oct 18, 2016
  10. kukelekuuk

    kukelekuuk C͕̹̲̽ͪ͐ͩ̔L̜̦̝͈ͦ̿̾̿ḘA̻̗̤̳̐ͭ̆̿̃̑ͭN̊̓͑̇ͯ
    Builder ⛰️ Ex-EcoLeader ⚜️⚜️⚜️ Premium Upgrade

    Joined:
    May 25, 2011
    Messages:
    10,061
    Trophy Points:
    80,160
    Ratings:
    +6,925
    Let me guess, you replaced all parts that said "getContents()" with "getStorageContents()" and suddenly it was magically fixed.
     
  11. andrewkm

    Founder Premium Upgrade

    Joined:
    Apr 5, 2011
    Messages:
    20,683
    Trophy Points:
    102,160
    Ratings:
    +15,143
    Tested and fixed. Will be on the server once we go live with our major plugin re-write. Aiming for tonight.
     
  12. andrewkm

    Founder Premium Upgrade

    Joined:
    Apr 5, 2011
    Messages:
    20,683
    Trophy Points:
    102,160
    Ratings:
    +15,143
    This is now live and fixed.