Minecraft Username: @THCOOL Brief Description: I was buying some sandstone from the server shop. It sells at 264 per click meaning that my inventory should fill up quickly. I clicked for a continuous minute and noticed that my inventory was indeed full, however the sign would still take my money. Instructions: Fill your entire inventory. Go to server block shop. Start buying an item. Notice how your inventory is completely full, yet it is still taking money from you How many times did you recreate this bug?: A few (4-5) Result: Sign continued to take my money ($7,000 total) after my inventory was already full Expected Result: I expected to receive an error message stating that there was no room in my inventory and it wouldn't let me buy more until I made space Evidence: Showing that my inventory is completely full: It taking my money even though my inventory is already full:
It's due to the offhand slot being empty. When there's nothing in your offhand, the signs think you still have inventory space. It's a known bug, I'm just not sure if there's a solution in the works beyond put something in your offhand for the time being when you buy from signs like that.
Correct. www.ecocitycraft.com/forum/threads/trade-signs-stealing-money.147611 However, some of my tests showed that this bug kept existing with an item in the offhand slot.
Let me guess, you replaced all parts that said "getContents()" with "getStorageContents()" and suddenly it was magically fixed.
Tested and fixed. Will be on the server once we go live with our major plugin re-write. Aiming for tonight.