[Bug Report] Lottery

Discussion in 'Help & Support / Errors & Bugs' started by Obblebobble, Feb 16, 2016.

  1. Obblebobble

    Obblebobble Vault of ECC - Founder
    Builder ⛰️ Ex-President ⚒️⚒️ Premium Upgrade

    Joined:
    Jul 23, 2012
    Messages:
    1,399
    Trophy Points:
    45,490
    EcoDollars:
    $0
    Ratings:
    +1,494
    Minecraft Username: @Obblebobble

    Brief Description: Lottery andrew ???profit
    Instructions: /lot buy

    How many times did you recreate this bug?: Many

    Result: Decimals annoying. Taken/Added to account is that really needed? Ew new lottery.

    Expected Result: Normal lottery (please, I don't like decimals)

    Evidence:[ @andrewkm @JamieSinn

    Please don't kill me, andrew said I can tag you both.
     
  2. dgam02

    dgam02 ♫ Shitposting Ex-SA ♫
    Builder ⛰️ Ex-EcoLeader ⚜️⚜️⚜️ Premium Upgrade

    Joined:
    Jun 10, 2012
    Messages:
    3,353
    Trophy Points:
    90,160
    Gender:
    Male
    Ratings:
    +6,381
    Minecraft Username:
    dgam02
    Brief Description:
    Decimals in lotto when buying and upon lotto drawing as well as the addition of "X amount of money taken/added to your account" When a player has bought lotto tickets or has won a lotto.
    Instructions:
    Simply buy a lotto ticket and or watch lotto drawing. You will notice a .0 at the end of every number won in lotto
    How many times did you recreate this bug?:
    This bug was recreated about 10 times by both @andrewkm and numerous other users on the server at the time.
    Result:
    Its annoying.
    Expected Result:
    It shouldn't be annoying

    @andrewkm @JamieSinn
    Evidence:
     
    #2 dgam02, Feb 16, 2016
    Last edited: Feb 16, 2016
  3. OppyStoppy

    OppyStoppy Pain
    Builder ⛰️ Ex-President ⚒️⚒️ Premium Upgrade

    Joined:
    Mar 16, 2015
    Messages:
    1,336
    Trophy Points:
    31,355
    Gender:
    Male
    EcoDollars:
    $0
    Ratings:
    +636
    Weird thing is, it looks normal on minechat!?
     
  4. andrewkm

    Founder Premium Upgrade

    Joined:
    Apr 5, 2011
    Messages:
    20,683
    Trophy Points:
    102,160
    Ratings:
    +15,144
  5. FuryFudge

    FuryFudge IDK ask Fury
    Builder ⛰️ Ex-EcoLegend ⚜️⚜️⚜️⚜️ Prestige ⭐ IV ⭐ Premium Upgrade

    Joined:
    Sep 21, 2013
    Messages:
    3,186
    Trophy Points:
    90,160
    Gender:
    Male
    Ratings:
    +2,324
    It also shows this message when you win "[Money] has been added to your account" (pretty sure it didn't do that before):

    (Cropped for sensitive content)
     
  6. Obblebobble

    Obblebobble Vault of ECC - Founder
    Builder ⛰️ Ex-President ⚒️⚒️ Premium Upgrade

    Joined:
    Jul 23, 2012
    Messages:
    1,399
    Trophy Points:
    45,490
    EcoDollars:
    $0
    Ratings:
    +1,494
    Mentioned that in my report already, was sort of copying what Andrew wrote in global lol. Thanks for the screenshot :)
     
  7. SCgenesis

    SCgenesis Builder
    Builder ⛰️ Ex-EcoLeader ⚜️⚜️⚜️

    Joined:
    Sep 14, 2015
    Messages:
    376
    Trophy Points:
    18,190
    Gender:
    Male
    Ratings:
    +245
    that's super annoying... I didn't notice because it doesn't show up on minechat.
     
  8. JamieSinn

    JamieSinn Retired Lead Administrator/Developer
    Builder ⛰️ Ex-Tycoon ⚜️⚜️⚜️ Premium Upgrade

    Joined:
    Jun 4, 2011
    Messages:
    5,517
    Trophy Points:
    78,090
    Gender:
    Male
    Ratings:
    +4,588
    The decimal I can fix, but not the messages taking or giving money. This is from our switch to use exclusively essentials for money in lotto
     
  9. kukelekuuk

    kukelekuuk C͕̹̲̽ͪ͐ͩ̔L̜̦̝͈ͦ̿̾̿ḘA̻̗̤̳̐ͭ̆̿̃̑ͭN̊̓͑̇ͯ
    Builder ⛰️ Ex-EcoLeader ⚜️⚜️⚜️ Premium Upgrade

    Joined:
    May 25, 2011
    Messages:
    10,061
    Trophy Points:
    80,160
    Ratings:
    +6,925
    You have a custom essentials, you're not going to tell me you can't make a function to take money without that message, lol. (in fact, it should already exist. Considering that's what Vault uses in the first place.)

    I'm sure it's because you're directly using User#takeMoney(amount) and User#giveMoney(amount) instead of using the Economy API.
     
    #9 kukelekuuk, Feb 16, 2016
    Last edited: Feb 16, 2016
  10. JamieSinn

    JamieSinn Retired Lead Administrator/Developer
    Builder ⛰️ Ex-Tycoon ⚜️⚜️⚜️ Premium Upgrade

    Joined:
    Jun 4, 2011
    Messages:
    5,517
    Trophy Points:
    78,090
    Gender:
    Male
    Ratings:
    +4,588
    We try to avoid editing essentials to add small features.
    The point of doing it like this is to have trade logs usable for finding lottery purchases, using the eco api has it's own trade log. Going back to square one for what our goal is.
     
  11. kukelekuuk

    kukelekuuk C͕̹̲̽ͪ͐ͩ̔L̜̦̝͈ͦ̿̾̿ḘA̻̗̤̳̐ͭ̆̿̃̑ͭN̊̓͑̇ͯ
    Builder ⛰️ Ex-EcoLeader ⚜️⚜️⚜️ Premium Upgrade

    Joined:
    May 25, 2011
    Messages:
    10,061
    Trophy Points:
    80,160
    Ratings:
    +6,925
    Why? So you can still merge EssentialsX changes?
     
  12. JamieSinn

    JamieSinn Retired Lead Administrator/Developer
    Builder ⛰️ Ex-Tycoon ⚜️⚜️⚜️ Premium Upgrade

    Joined:
    Jun 4, 2011
    Messages:
    5,517
    Trophy Points:
    78,090
    Gender:
    Male
    Ratings:
    +4,588
    We haven't discussed that yet, but possibly.
    It's more for stability, as the server's core is essentials, and mucking it up cannot be afforded.
     
  13. BrokeMel

    BrokeMel broke
    Resident ⛰️ Ex-Tycoon ⚜️⚜️⚜️ Premium Upgrade

    Joined:
    Jul 26, 2013
    Messages:
    1,018
    Trophy Points:
    61,160
    Gender:
    Female
    Ratings:
    +830
    How long until lotto draws?
    [​IMG]
    Yes okay thank you lotto -_-

    Happens if you do /lot just before it draws.

    UGH I keep coming back and doing /lot the second before it draws.
     
    #13 BrokeMel, Feb 16, 2016
    Last edited: Feb 16, 2016
  14. kukelekuuk

    kukelekuuk C͕̹̲̽ͪ͐ͩ̔L̜̦̝͈ͦ̿̾̿ḘA̻̗̤̳̐ͭ̆̿̃̑ͭN̊̓͑̇ͯ
    Builder ⛰️ Ex-EcoLeader ⚜️⚜️⚜️ Premium Upgrade

    Joined:
    May 25, 2011
    Messages:
    10,061
    Trophy Points:
    80,160
    Ratings:
    +6,925
    That's intended. Lottery tends to lag a bit when the TPS is low and a lot of tickets were bought. So when people type /lot during that time it just says "soon" but it means "less than a second" generally.
     
  15. BrokeMel

    BrokeMel broke
    Resident ⛰️ Ex-Tycoon ⚜️⚜️⚜️ Premium Upgrade

    Joined:
    Jul 26, 2013
    Messages:
    1,018
    Trophy Points:
    61,160
    Gender:
    Female
    Ratings:
    +830
    What happened to "draw in: 0 seconds"?
     
  16. andrewkm

    Founder Premium Upgrade

    Joined:
    Apr 5, 2011
    Messages:
    20,683
    Trophy Points:
    102,160
    Ratings:
    +15,144
    We don't use anything from EssentialsX and are avoiding it completely. Too much pointless non-sense in there.
     
    • Like Like x 1
    • Informative Informative x 1
    • List
  17. kukelekuuk

    kukelekuuk C͕̹̲̽ͪ͐ͩ̔L̜̦̝͈ͦ̿̾̿ḘA̻̗̤̳̐ͭ̆̿̃̑ͭN̊̓͑̇ͯ
    Builder ⛰️ Ex-EcoLeader ⚜️⚜️⚜️ Premium Upgrade

    Joined:
    May 25, 2011
    Messages:
    10,061
    Trophy Points:
    80,160
    Ratings:
    +6,925
    Fair enough. I can't disagree with that.

    I don't recall that ever existing.
     
    • Like Like x 1
    • Potato Potato x 1
    • List
    #17 kukelekuuk, Feb 17, 2016
    Last edited: Feb 17, 2016
  18. SuburbSomeone

    SuburbSomeone Shrubby Tycoon
    Builder ⛰️ Ex-Tycoon ⚜️⚜️⚜️ Premium Upgrade

    Joined:
    Apr 9, 2013
    Messages:
    3,337
    Trophy Points:
    74,090
    Gender:
    Male
    EcoDollars:
    $0
    Ratings:
    +6,479
    So can the decimal be fixed? :3
     
  19. Obblebobble

    Obblebobble Vault of ECC - Founder
    Builder ⛰️ Ex-President ⚒️⚒️ Premium Upgrade

    Joined:
    Jul 23, 2012
    Messages:
    1,399
    Trophy Points:
    45,490
    EcoDollars:
    $0
    Ratings:
    +1,494
    I believe Jamie has removed it. Needs to be added that's all.
     
  20. BrokeMel

    BrokeMel broke
    Resident ⛰️ Ex-Tycoon ⚜️⚜️⚜️ Premium Upgrade

    Joined:
    Jul 26, 2013
    Messages:
    1,018
    Trophy Points:
    61,160
    Gender:
    Female
    Ratings:
    +830
    I'd love to prove that it did but idk if I can sort through 5.6k screenshots...
    k found one. Will upload when internet.
     
    #20 BrokeMel, Feb 17, 2016
    Last edited: Feb 17, 2016