Accepted [All Main Servers Suggestion] Include Magic/Pres Sale values /sellpam

Discussion in 'Suggestions' started by Commander_HK47, Jan 19, 2021.

Thread Status:
Not open for further replies.
  1. Commander_HK47

    Commander_HK47 ECC Sponsor
    ECC Sponsor Builder ⛰️ Ex-EcoLegend ⚜️⚜️⚜️⚜️ Prestige ⭐ I ⭐ Premium Upgrade

    Joined:
    Dec 28, 2020
    Messages:
    77
    Trophy Points:
    40,920
    Ratings:
    +29
    In Game Name:
    Commander_HK47
    What part of EcoCityCraft is this suggestion for:
    All Main Servers
    Short title for your suggestion:
    Include Magic/Pres Sale values /sellpam
    What are you suggesting:
    The /sellspam command is a great addition to reduce chat clutter, but i think it could be even better if in the hidden state it also included the magic and prestige sale values summed into to the total worth print out line for a true total sale value.
    Why is this a good addition for EcoCityCraft?:
    Further improvement for an already great QOL feature.
    Other information:

    Plugin or custom addition:

    One suggestion per form:
    I Understand.
     
    • Like Like x 2
    • Winner Winner x 1
    • List
    #1 Commander_HK47, Jan 19, 2021
    Last edited: Jan 21, 2021
  2. FirstNolan

    FirstNolan Former GameAdmin
    ECC Sponsor Mayor ⛰️⛰️ Ex-EcoLegend ⚜️⚜️⚜️⚜️ Prestige ⭐ I ⭐ Premium Upgrade

    Joined:
    Aug 23, 2020
    Messages:
    1,125
    Trophy Points:
    45,710
    Gender:
    Male
    Ratings:
    +285
    I think /sellspam is intended to have the most "bare-bones" approach to /sell, which would only give you the total of what you make when you execute the command /sell. I don't really see a purpose of adding magic/prestige to /sellspam, as it would just clutter it again. The best solution in my mind to make everyone happy is to choose not to use /sellpspam if you want to see how much money you make from magic and prestige.

    -1
     
  3. Schloty

    Schloty Professional Money Grinder
    President ⛰️⛰️ Ex-EcoLegend ⚜️⚜️⚜️⚜️ Prestige ⭐ II ⭐ Premium Upgrade

    Joined:
    Jun 18, 2012
    Messages:
    749
    Trophy Points:
    66,910
    Gender:
    Male
    Ratings:
    +198
    As I was the one who originally suggested sell spam I will put my input in to this. First off, I think you may be a bit confused on what this suggestion is actually suggesting. Currently, when you do /sellspam, what shows up is the total value of the items that you sold to the server, at the server price. What this suggestion is suggesting (I think) is that that number that pops up he representative of the sell price to the server + magic + prestige, but still only being one number. The current system of only showing the server price can be a bit misleading as you’re actually making 5-150% more than what that number there shows.

    However, I feel as if this suggestion could potentially be difficult to implement and would require a fair bit of coding to make it work. If that is not the case, then +1
     
  4. Commander_HK47

    Commander_HK47 ECC Sponsor
    ECC Sponsor Builder ⛰️ Ex-EcoLegend ⚜️⚜️⚜️⚜️ Prestige ⭐ I ⭐ Premium Upgrade

    Joined:
    Dec 28, 2020
    Messages:
    77
    Trophy Points:
    40,920
    Ratings:
    +29
    You are interrupting my suggestion correctly Total sale price would = (Server sell price + Magic + Prestige). It would still remain a one line console output.

    Could it be something as simple as returning the output from server sale transaction function as a float, and then doing the same for the magic/prestige values, then doing an add operation on the two returned values and storing the results in a 3rd float before writing that third value to to console as the full total?
     
    #4 Commander_HK47, Jan 22, 2021
    Last edited: Jan 22, 2021
  5. andrewkm

    Founder Premium Upgrade

    Joined:
    Apr 5, 2011
    Messages:
    20,375
    Trophy Points:
    102,160
    Ratings:
    +15,066
    The /sellspam total worth message doesn't include the prestige bonus.
    We will fix this. Added to our development todo list.

    Regarding the Magic Item bonus, this is also included in the /sellspam final total.
    You're just looking at it wrong. Sell ten salmon without a magic salmon, and then sell ten salmon, with a magic salmon.
    Observe the total. ;)
     
    #5 andrewkm, Jan 22, 2021
    Last edited: Jan 22, 2021
  6. andrewkm

    Founder Premium Upgrade

    Joined:
    Apr 5, 2011
    Messages:
    20,375
    Trophy Points:
    102,160
    Ratings:
    +15,066
    /sellspam in regards to the Prestige Bonus has now been fixed/implemented. :)
     
Thread Status:
Not open for further replies.