Villager type misnamed

Installing what? I'm confused. The villagers should only stack with their profession

 

Can confirm. I have a group of nitwits that are buying paper.

 

Just thought I'd throw this out. I have a tool smith that buys wool (like a shepherd) but also buys iron and sells tools. He was the last villager in a small stack (I killed the others with lava).

 

I noticed this exact thing going on with my villagers. I too have (or had as I haven’t looked to see if it straightened itself out) a villager who was titled “tool smith”, but he sold armor and wool. Also, I name tagged all the villagers from that stack, which they did separate and seemed to be normal, but the next day their name tags disappeared and they were stacked again offering funky deals.

 

Name tagging them splits them out, however they seem to be splitting back in after a while.
We are looking into preventing named mobs from stacking.

I've mentioned the above problems to the developer of the plugin. Please be patient.

 

@Zombie_Jamboree @padsen @EMACheung @Ladyvamptress the developer has done quite a bit of work towards villager stacking.

The following changes have been pushed for us:
- Made villager differentiation more specific (Solves: https://github.com/Nathat23/StackMob-2/issues/56)
- Inconstant removal of stack status (Solves: https://github.com/Nathat23/StackMob-2/issues/51)

These changes are now live. Please let us know how things are going.
@Gluupor would be nice if you can shoot some tests at this as well as I know you deal with villagers quite a bit.

 

so i did some testing and i actually live witnessed the merging of a tool smith and an armor smith. so despite the plugin maker actually respecting the careers in his plugin:

Code:

if(sm.getVersionId() >= 6){
                   ((Villager) dupe).setCareer(((Villager) original).getCareer());

which would be inline with how the villagers are grouped (as outlined here: https://minecraft.gamepedia.com/Villager#Professions_and_careers),
villagers with different careers still seem to stack.

if stacked correctly one should eventually have 13 stacks, one for each career possible. while writing this i accumulated 6 stacks with a number on each so by now i should have had every possible career spawned. what i got is actually the exact number of professions (6).

the stackmob dev actually also gets the bukkit version in his code, which is setting a variable to 6 if the version he got from bukkit contains "1.12.2" so maybe that might be where the error is, that infact the versionid is set to something else than 6 and the code respecting the careers is never executed (just a wild guess).

im quite tired now so i might be messing stuff up. maybe take another look @ the commit the guy added to https://github.com/Nathat23/StackMob-2/issues/56

so since i took a while to write this more villagers have spawned and im still @ 6 stacks.
hope this helps at least to some degree

 

i actually set up a spawner with a collection area below so if you need to do some testing feel free to use that.
coords:
XYZ: 1811 27 1194
feel free to kill of the stacks that are in the basin (only those IN the basin please ) if you need to have a fresh start.
i am off to bed now

 

Thanks @Gluupor I've forwarded your findings to the developer via the issue.
Hopefully he can have another peek and see what's going on here .

 

@Zombie_Jamboree @padsen @EMACheung @Ladyvamptress @Gluupor
We have made yet another update with changes from the developer.
Please do some testing and get back to us. Would mean a lot !

 

with the latest fix villager now stack according to their career (eg. fisherman, armor smith, ...)
so now there is 1 stack for each career(13):

 

Thanks so much for the tests.
I will be closing the github issue now .