[ShopDB] Updates / Changelog

Discussion in 'General Discussion' started by Kozz, Dec 20, 2019.

  1. Jdawger

    Jdawger Goes by Brass Scribe everwhere except MC & ECC
    ECC Sponsor President ⛰️⛰️ Ex-EcoLegend ⚜️⚜️⚜️⚜️ Prestige ⭐ III ⭐ Gameplay Architect Premium Upgrade

    Joined:
    Dec 15, 2013
    Messages:
    4,098
    Trophy Points:
    88,160
    Gender:
    Male
    Ratings:
    +3,270
    Woof. I should’ve read lol
     
  2. Kozz

    Developer Builder ⛰️ Ex-President ⚒️⚒️ Gameplay Architect

    Joined:
    Jan 11, 2017
    Messages:
    273
    Trophy Points:
    28,460
    EcoDollars:
    $0
    Ratings:
    +430

    New Shop Panel


    [​IMG]

    Updating Shop Modal


    [​IMG]


    Quickly whipping up these designs atm. They may change a bit (e.g, button colors).

    Fields
    Shop: the shop
    Server: the server
    Owner: the shop owner (this is determined by the player with the most signs in the shop, so may not be 100% accurate. I don't want to manually update shop owners, that would be a hassle)
    Items Traded: Total unique number of items bought + sold at the shop.
    Edit: to edit the shop. Needs a token which I'll assign to people I trust to help me add/remove/update shops.


    I'm still working hard! Let's see if I can release this today.
     
    • Winner Winner x 4
    • Potato Potato x 1
    • List
  3. Cas_with_a_K

    Cas_with_a_K President
    President ⛰️⛰️ Ex-President ⚒️⚒️

    Joined:
    Feb 16, 2019
    Messages:
    172
    Trophy Points:
    6,460
    Gender:
    Female
    Ratings:
    +107
    what is the purpose of 'item traded' tab?
     
  4. Kozz

    Developer Builder ⛰️ Ex-President ⚒️⚒️ Gameplay Architect

    Joined:
    Jan 11, 2017
    Messages:
    273
    Trophy Points:
    28,460
    EcoDollars:
    $0
    Ratings:
    +430
    Shows the amount of unique items being purchased + sold at the shop.

    This is currently a placeholder for some awesome (future) features I have in mind:
    • Clicking on it will open up a profile of the shop, showing all the items being bought or sold.
    • 'Analysis' of the shop can be performed:
      • Compares the price of each item over the average buy/sell price for that item, and indicates whether the price is good, fair, or poor
      • This will be awesome for shop owners to see all the items they have in one place and how they compare to other shops.
     
    • Winner Winner x 2
    • Potato Potato x 1
    • List
    #64 Kozz, Feb 16, 2020
    Last edited: Feb 16, 2020
  5. Kozz

    Developer Builder ⛰️ Ex-President ⚒️⚒️ Gameplay Architect

    Joined:
    Jan 11, 2017
    Messages:
    273
    Trophy Points:
    28,460
    EcoDollars:
    $0
    Ratings:
    +430
    02/16/2020 2:45 PM (CST):
    I will be performing updates. Expect down time to be up-to two hours.
     
    #65 Kozz, Feb 16, 2020
    Last edited: Feb 16, 2020
  6. Kozz

    Developer Builder ⛰️ Ex-President ⚒️⚒️ Gameplay Architect

    Joined:
    Jan 11, 2017
    Messages:
    273
    Trophy Points:
    28,460
    EcoDollars:
    $0
    Ratings:
    +430
    02/16/2020 2:51 PM (CST):
    Update completed in ~5 minutes
    I'm getting better at this. :)

    [UPDATE] [V1.0.3]:

    • Completely redesigned item tables
    • Completely redesigned shop tables
    • Overall, better user experience
     
    • Winner Winner x 1
    • Potato Potato x 1
    • List
  7. ChirauxM

    ChirauxM Builder
    Builder ⛰️ Ex-Mayor ⚒️⚒️

    Joined:
    Jan 19, 2020
    Messages:
    7
    Trophy Points:
    2,685
    Gender:
    Male
    Ratings:
    +1
    am i supposed to be able to edit/add shops?
     
  8. Kozz

    Developer Builder ⛰️ Ex-President ⚒️⚒️ Gameplay Architect

    Joined:
    Jan 11, 2017
    Messages:
    273
    Trophy Points:
    28,460
    EcoDollars:
    $0
    Ratings:
    +430
    Players have to enter a token (passcode) to update the shops.

    These tokens will be assigned to approved users who are willing to add, remove, or modify shops.

    This is a common report, I’ll figure out a way to make it more clear that it’s for authenticated users only. Nonetheless, thank you to those who warned me about this!
     
    #68 Kozz, Feb 17, 2020
    Last edited: Feb 17, 2020
  9. ChirauxM

    ChirauxM Builder
    Builder ⛰️ Ex-Mayor ⚒️⚒️

    Joined:
    Jan 19, 2020
    Messages:
    7
    Trophy Points:
    2,685
    Gender:
    Male
    Ratings:
    +1
    Ah jeez, sorry. Does creating a shop work the same way?
     
  10. Kozz

    Developer Builder ⛰️ Ex-President ⚒️⚒️ Gameplay Architect

    Joined:
    Jan 11, 2017
    Messages:
    273
    Trophy Points:
    28,460
    EcoDollars:
    $0
    Ratings:
    +430
    Yes
     
    • Like Like x 1
    • Potato Potato x 1
    • List
  11. SplayTick

    Mythic ⚔️ I ⚔️ ECC Sponsor EcoLegend ⛰️⛰️⛰️⛰️ Ex-EcoMaster ⚜️⚜️⚜️⚜️ Prestige ⭐ V ⭐ Premium Upgrade

    Joined:
    Jan 17, 2020
    Messages:
    195
    Trophy Points:
    43,110
    Gender:
    Male
    Ratings:
    +75
    Does this pull directly from the database that the chest shop plugin runs off of? if so would there be a way to add a binary in stock field to the database and edit the method that returns the "This shop is out of stock" message to update that binary field with a 0 for out of stock that can then be read by shopdb? I'm sorry if this is in no way possible. I'm not sure how much freedom you have with the plugins.
     
  12. Kozz

    Developer Builder ⛰️ Ex-President ⚒️⚒️ Gameplay Architect

    Joined:
    Jan 11, 2017
    Messages:
    273
    Trophy Points:
    28,460
    EcoDollars:
    $0
    Ratings:
    +430
    Hey SplayTick,
    This is actually not a plugin at all.
    This is something I've programmed and runs entirely independently of the server.

    The mod which allows any player to update the shops scans the shops specified boundaries and parses valid trade signs to find which items the shop is buying or selling.

    Since there is no way (that I know of) on the client-side to read the contents of a locked chest (or even an unlocked one for that matter - the contents of a chest is stored on the server, and that information is not available on our Minecraft client until we actually open the chest).
    Thus, there is no way to programatically tell if the shock is out of stock or not when scanning.
     
    #72 Kozz, Feb 18, 2020
    Last edited: Feb 18, 2020
  13. SplayTick

    Mythic ⚔️ I ⚔️ ECC Sponsor EcoLegend ⛰️⛰️⛰️⛰️ Ex-EcoMaster ⚜️⚜️⚜️⚜️ Prestige ⭐ V ⭐ Premium Upgrade

    Joined:
    Jan 17, 2020
    Messages:
    195
    Trophy Points:
    43,110
    Gender:
    Male
    Ratings:
    +75
    ok. I thought the shopdb site interacted with a dataset on the minecraft server to get the list of items sold at each shop and the amounts.
     
  14. Kozz

    Developer Builder ⛰️ Ex-President ⚒️⚒️ Gameplay Architect

    Joined:
    Jan 11, 2017
    Messages:
    273
    Trophy Points:
    28,460
    EcoDollars:
    $0
    Ratings:
    +430
    That would be ideal, but is not the case at the moment
     
  15. SplayTick

    Mythic ⚔️ I ⚔️ ECC Sponsor EcoLegend ⛰️⛰️⛰️⛰️ Ex-EcoMaster ⚜️⚜️⚜️⚜️ Prestige ⭐ V ⭐ Premium Upgrade

    Joined:
    Jan 17, 2020
    Messages:
    195
    Trophy Points:
    43,110
    Gender:
    Male
    Ratings:
    +75
    Understandable. I was also wondering if there would be any way of having something like a weekly csv available for download. It wouldn't have to be a exhaustive list of every item at every shop. Just something that would give the mean price for each item. I know this wouldn't be the most accurate unless we could get all shop owners to use the mod and update their shops regularly but it could help shops be more competitive with their pricing.
     
  16. Kozz

    Developer Builder ⛰️ Ex-President ⚒️⚒️ Gameplay Architect

    Joined:
    Jan 11, 2017
    Messages:
    273
    Trophy Points:
    28,460
    EcoDollars:
    $0
    Ratings:
    +430
    Update [HOTFIX]
    Unfortunately, only authorized users may update shop items from now on.

    Due to reverse-engineering / exploitation of a method that was publicly available to allow all users to update shop items,
    malicious users were able to upload fake items or even modify existing items.

    This was not a vulnerability, rather it was misuse of an intended feature which allowed any player to update shops.

    @UnitedStates2, thank you for alerting me about this.

    There is no work-around, and I'm afraid not just anybody can be allowed to update items anymore.
    The discovery of this exploit was alerted to me just recently today, and I rolled out this hotfix within the same hour.

    I will work on getting members of staff or other trusted people to help me update shop items. They will be updated at least once per day.
     
    #76 Kozz, Feb 22, 2020
    Last edited: Feb 22, 2020
  17. kukelekuuk

    kukelekuuk C͕̹̲̽ͪ͐ͩ̔L̜̦̝͈ͦ̿̾̿ḘA̻̗̤̳̐ͭ̆̿̃̑ͭN̊̓͑̇ͯ
    Builder ⛰️ Ex-EcoLeader ⚜️⚜️⚜️ Premium Upgrade

    Joined:
    May 25, 2011
    Messages:
    10,061
    Trophy Points:
    80,160
    Ratings:
    +6,925
    You're describing a vulnerability. Lack of authentication process is a vulnerability. An actually secure solution wouldn't rely on the good will of the client and just trusting nobody will ever be bored enough to exploit that trust. Aka, it wouldn't use a mod, or if it did use a mod, it'd need a server-side token request to ensure authentication.
     
    • Like Like x 1
    • Winner Winner x 1
    • List
    #77 kukelekuuk, Feb 22, 2020
    Last edited: Feb 22, 2020
  18. Kozz

    Developer Builder ⛰️ Ex-President ⚒️⚒️ Gameplay Architect

    Joined:
    Jan 11, 2017
    Messages:
    273
    Trophy Points:
    28,460
    EcoDollars:
    $0
    Ratings:
    +430
    Well, there's an authentication process now. :)
    Unfortunately there is no way to implement an authentication process and simultaneously allow everybody to be able to update shops.
     
  19. kukelekuuk

    kukelekuuk C͕̹̲̽ͪ͐ͩ̔L̜̦̝͈ͦ̿̾̿ḘA̻̗̤̳̐ͭ̆̿̃̑ͭN̊̓͑̇ͯ
    Builder ⛰️ Ex-EcoLeader ⚜️⚜️⚜️ Premium Upgrade

    Joined:
    May 25, 2011
    Messages:
    10,061
    Trophy Points:
    80,160
    Ratings:
    +6,925
    With a server-side plugin authenticating a client as long as they're online you could.
     
  20. Kozz

    Developer Builder ⛰️ Ex-President ⚒️⚒️ Gameplay Architect

    Joined:
    Jan 11, 2017
    Messages:
    273
    Trophy Points:
    28,460
    EcoDollars:
    $0
    Ratings:
    +430
    You're exactly right! This is the first project like this I have released, and it is still considered in beta for reasons like this.

    The latter is exactly what I have implemented.
    It actually was already in place, though this server-side token was shared publicly with the client.